Skip to content

Added updateCaveat action#1071

Merged
hmalik88 merged 4 commits into
mainfrom
hm/update-permission-controller-actions
Jan 24, 2023
Merged

Added updateCaveat action#1071
hmalik88 merged 4 commits into
mainfrom
hm/update-permission-controller-actions

Conversation

@hmalik88
Copy link
Copy Markdown
Contributor

@hmalik88 hmalik88 commented Jan 19, 2023

See https://github.com/MetaMask/MetaMask-planning/issues/297

Added action for updating a caveat, will need this action to be able to update the wallet_snap permission's snapIds caveat type in the SnapController.

@hmalik88 hmalik88 requested a review from a team as a code owner January 19, 2023 21:44
@hmalik88 hmalik88 changed the title Added updateCaveat actions Added updateCaveat action Jan 19, 2023
Comment thread packages/permission-controller/src/PermissionController.ts
Comment thread packages/permission-controller/src/PermissionController.test.ts
Comment thread packages/permission-controller/src/PermissionController.ts
Comment thread packages/permission-controller/src/PermissionController.ts
Copy link
Copy Markdown
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@hmalik88 hmalik88 merged commit 0192798 into main Jan 24, 2023
@hmalik88 hmalik88 deleted the hm/update-permission-controller-actions branch January 24, 2023 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants